add NV policy chart and values configs #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krumware
requested changes
Feb 8, 2024
There was a problem hiding this comment.
I'd like to also surface the new values to the helm/gen3 values so that they're more prominent.
from slack, it might also be helpful to go ahead and add the global variable and prepare for adding a conditional chart dependency
neuvector:
enabled: false
policies:
## on the fence about this variable name
include: true
defaultMode: Monitor
nameOverride: ""
fullnameOverride: ""
# hostname/service name for our DB
DB_HOST: development-gen3-postgresql
# Prefix for relevant services deployed through Argo
ARGOCD_PREFIX: development-gen3
# Neuvector policy enforcement mode
# dev: Monitor
# prod: Protect
ingress:
# service name of your ingress controller
controller: nginx-ingress-controller
# installation namespace of your ingress controller
namespace: nginx
# classname of your ingress
class: nginx
|
@krumware Pinging for re-review, should have knocked out your change requests |
add descriptive comments for neuvector
|
Made a few changes to resolve linting and to add some references as inline docs. |
krumware
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds neuvector security policies and config to gen3-helm